Repository navigation
Update Navigation component version to 2.4.2 - #16632
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
|
@ashiagr I converted this PR back to draft due to the lint error. Sorry about that. I'll try to address it as soon as I can. |
|
@ashiagr I've addressed the lint issue, updated the PR description and marked the PR ready for review. I am sorry about the extra pings. |
|
@wordpress-mobile/owl-team The transient dependency version changes resulting from this update is a bit worrisome. We are already not using the declared dependencies for most of these dependencies, but it'd have been better if we could update those before we had to update the navigation component. Historically we have turned a blind eye to these transient version updates and I'd really like to change that and that's why I've been working on the dependency catalog infrastructure. Having said that, practically speaking I think it might makes sense to still merge this PR especially since it's somewhat of a blocker for the Plugin DSL work in #15314. I am saying I can see 3 ways forward:
I don't have a strong opinion, but if I had to make a decision, I'd stay practical and go with option 1. What do you think? |
| ), | ||
| navOptions | ||
| ) | ||
| outputFileExtension?.let { |
There was a problem hiding this comment.
Warning (Edit it, a toast starts to appear saying Failed to crop and save image, please try again..
I also reviewed the outputFileExtension argument and it was evident that it was defined as expected within the navigation graph, which is nullable, so this got me by surprise, meaning how come the auto-generated PreviewImageFragmentDirections.actionPreviewFragmentToCropFragment(...) action didn't pick that up. 🤔
After searching a bit, I found this issue within Google's issue tracker and it got me thinking if us adding the android:defaultValue="@null" to this outputFileExtension argument within the navigation graph will help to both fix the compile and runtime issue. I actually tried that and it seems to work. 🎉
@ashiagr can you verify that the above problem and potential solution is what you would expect as well? 🙇
There was a problem hiding this comment.
Great find, @ParaskP7. I tested the scenario and indeed the issue is resolved by the solution you mentioned. Thanks for linking the Android issue.
Also thanks @oguzkocer for updating the library. 🙇♀️
We should
- Remove
null-check added foroutputFileExtensionin f73798c. - Add
android:defaultValue="@null"tooutputFileExtensionargument within the navigation graph for both the fragments:preview_destandcrop_dest.
@oguzkocer, let me know if it can be handled as part of this PR itself or if I should create another PR with a fix. 🙏
There was a problem hiding this comment.
Thank for the confirmation and testing this solution @ashiagr ! 🙇 🚀
There was a problem hiding this comment.
Changes in 51af542 look good to me, thanks @oguzkocer!
|
|
||
| There are several bug fix reports in ther lifecycle release notes. I can see 5 bug fixes | ||
| related to it if I search for `NullSafeMutableLiveData`: | ||
| * https://developer.android.com/jetpack/androidx/releases/lifecycle NullSafeMutableLiveData) |
There was a problem hiding this comment.
Praise (❤️): @oguzkocer This is a good catch about the various bugs with NullSafeMutableLiveData and the fact that the latest stable lifecycle version of 2.4.1 should address them. It might be good if this would be our next dependency to update.
There was a problem hiding this comment.
@ParaskP7 Unfortunately lifecycle 2.4.1 in combination of this navigation component update doesn't seem to fix all the issues we are having. I ran a quick test yesterday and I still had some crashes. Having said that, I agree with updating lifecycle as our next dependency and trying to re-enable this check. 🤞 I missed something in my test run and it will work with that update.
There was a problem hiding this comment.
Yes, exactly, as per my comment below I don't think that updating lifecycle to 2.4.1 will fix all those 35 issues, maybe some of them. I still think that the rest of them are valid errors that we will need to fix anyway.
PS: I am actually not sure why Lint didn't error on those before and it did only after updating navigation to 2.4.2. Maybe those were warnings instead of errors before, maybe this navigation update added transitive dependencies that made this NullSafeMutableLiveData thing more strict on the Lint side of things, not sure... 🤷
|
|
||
| Disabling this from `lint.xml` file doesn't seem to work, that's why it's added here. | ||
| */ | ||
| disable "NullSafeMutableLiveData" |
There was a problem hiding this comment.
Suggestion (💡): @oguzkocer Having said the above I still believe that this NullSafeMutableLiveData check is a valid check, that produces good results, even with our current 2.2.0 version of lifecycle. As such, I wouldn't recommend disabling it at this point.
Out of the 35, I can totally recommend suppressing 10 of them (inline and closer to the source), as they indeed seem false positives to me, but for the rest I recommend fixing them. I actually spend a bit of time on it and the fixes are not that hard. I can share the patch I ended up with if you like.
PS: Maybe the newest 2.4.1 version of the lifecycle library would automatically fix those 10 false positives that I noticed. 🤷
There was a problem hiding this comment.
@ParaskP7 If we don't disable the check, lint task crashes due to a bug in NullSafeMutableLiveData checks. This is explained in this comment:
We are disabling this check for now as it results in a crash, but we should try to enable it again as we update our
lifecycleversion.
There was a problem hiding this comment.
@oguzkocer This is very interesting that lint task crashed on your side, it doesn't crash for me locally, do you mean it crashed on CI maybe? 🤔 Locally for me it completes successfully with a failure because of those 35 new errors. Maybe I am still misunderstanding something in terms of the task crashing... 🤷
There was a problem hiding this comment.
PS: After removing disable "NullSafeMutableLiveData", I actually managed to run Lint successfully after fixing quickly those 25 NullSafeMutableLiveData Lint errors and suppressing 10 of those, without even a failure.
There was a problem hiding this comment.
UPDATE: Ok, I am now making progress and updating to 2.4.1 works. However, it added 10 more NullSafeMutableLiveData, which to be honest, from the release notes, it is actually expected. This probably why Lint was failing with those weird errors that got it crashing. 🤞
PS: I am running out of time today, I'll continue with this tomorrow. I converted the my accompanying PR back to draft for now.
There was a problem hiding this comment.
@ParaskP7 Thank you for posting your understanding, it's in line with my findings. I tried to explain exactly these in the code comments from this PR. Maybe those make more sense now? Let me know if you have suggestions to improve them.
Good catch on the double lifecycleVersion! That might be the issue I had in my brief try with the updated lifecycleVersion. I don't think it changes this PR or the recommendation of trying to re-enable the lint check with the new lifecycleVersion when we update it. However, it might change our prioritization of when we'll do that lifecycleVersion update.
I think we are finally on the same page about the issue. Since this PR and plugin DSL are prerequisite to your project, I am happy to leave the decision of whether to merge this as is or address the lint issue first. However, in my opinion, it might be good to time box your work on this. Lint checks are important, but a single lint check being disabled for a few sprints (if necessary) will not have a significant impact on the project - if it did, we'd prioritize fixing those lint warnings in the first place. I think this is especially true for this particular lint check as it has quite a few implementation bugs and doesn't seem mature yet.
There was a problem hiding this comment.
UPDATE: Ok, I am now making progress and updating to 2.4.1 works. However, it added 10 more NullSafeMutableLiveData, which to be honest, from the release notes, it is actually expected. This probably why Lint was failing with those weird errors that got it crashing. 🤞
Just wanted to note that I saw this comment after I posted my last comment. 🤞 it works!
There was a problem hiding this comment.
👋 @oguzkocer !
Yes, we are on the same page now! 💯
I agree with timeboxing the Lint error resolution work I am doing, I think I did the bulk already and it will only take me a couple of additional hours today to complete it (maybe less). So, let ne give this a try today as well and then we can disable this Lint check if the update to 2.4.1 fails as well.
Will keep you posted! 🤞
There was a problem hiding this comment.
UPDATE: And success, updating lifecycle to 2.4.1 and resolving/suppressing those 10 new NullSafeMutableLiveData lint errors did the trick. As such, the accompanying PR is now ready for review again. 🎉
|
👋 @oguzkocer and thanks this update PR! 🥇
True... 🤔
This is very thoughtful, I agree. 💯 At some point I want to also bring to our attention this dependency-analysis-android-gradle-plugin plugin, which amongst other things it does, it is really good on helping with
I personally agree. 👍
I agree. We should just be really thorough with our testing before merging this PR with
We can do that too, but it depends on how we would like to proceed going forward and with which projects. 🤔
I would personally take the risk and proceed with the Plugin DSL PR and all the work needed to be done to help with that (like this PR) and not keep pushing this change for later. However, I do understand if we decide to do it the other way around. 🤔
I am with you on that. I would choose option 1. too. 👍 |
There are currently 32 errors related to 'NullSafeMutableLiveData'. All those will get resolved or suppressed locally in subsequent commits.
The 'mutableSnackbarMessage' mutable live data value is set to null during 'onCleared()' and as such it needs to be declared as nullable. Then, using 'let' on the 'snackbarMessage' live data this can be guarded against so that to avoid a null pointer exception.
The 'showErrorMessage' mutable live data value is set to
'event.error.message' on multiple occasions. However, 'event.error' can
be nullable and as such the 'event.error.message' itself.
There is an 'if (event.isError) { ... }' statement above to guard from
that ever happening, but the compiler is not smart enough to understand
that. Maybe with 'Kotlin Contracts' this problem would have been
avoided, but this feature is a separate discussion of its own.
Thus, by guarding this with 'let' before setting this 'showErrorMessage'
mutable live data is the best that can be done at this point of time.
The 'supportedStates' mutable live data value is set to null during 'onCountrySelected(...)' and can be also set to null via the 'OnDomainSupportedStatesFetched.supportedStates' from within the 'SiteStore' as it is actually defined as nullable. As such, the 'supportedStates' itself needs to be declared as nullable.
The 'currentFeatureAnnouncement' mutable live data can be set to null during 'loadFeatures()' and via 'FeatureAnnouncementProvider.getLatestFeatureAnnouncement(...)' which might produce a nullable 'FeatureAnnouncement'. As such, the 'currentFeatureAnnouncement' itself needs to be declared as nullable. The rest of the changes are propagated due to the above change and are mainly guarding the rest of the functionality that depends on that with 'let' and '?' scope functions.
This 'LiveDataExtensions' is not used anywhere within the codebase and as such can be safely remove. If at any point in the future it will be needed again, engineers should either bring it back, with a more model version of it, or use another utility from the 'LiveData' library itself, which will serve the same purpose. This also solves two 'NullSafeMutableLiveData' lint errors related to this function.
For these classes in this commit the 'NullSafeMutableLiveData' Lint error is suppressed are false positive. It is false positive because the nullability of the variable is already checked before it is assigned to the mutable live data field, but it is anyway ignored as being potentially null and thus reported.
As part of this update the below occurred: - The 'lifecycle-extensions' artifact and APIs got removed as it has been deprecated since '2.2.0' and it is no longer updated. The recommendation nowadays is to instead add dependencies for the specific lifecycle artifacts needed. - Update 'ViewModelProvider.Factory.create(...)' signature to a non-null 'ViewModel' generic as it is now defined as such by the Java factory interface. The above were the only breaking change. Apart from that everything else seems to be compiling and working as expected (did a quick smoke test). However, this update added 10 new 'NullSafeMutableLiveData' lint errors that will be fixed in subsequent commits.
The 'data' mediator live data is set to null during the 'onCleared()'. As such, the 'data' itself needs to be declared as nullable. This use case's associated view model is updated accordingly. Also, this view model's associated fragment is treating this 'uiModel' live data value as nullable already.
The 'searchPages' mutable live data is set to null during 'clearSearch()'. As such, the 'searchPages' itself needs to be declared as nullable. Also, this view model's associated search view model is treating this 'searchPages' live data value as nullable already and guarding against it accordingly.
The 'searchPages' mutable live data is set to null during 'clearSearch()'. As such, the 'searchPages' itself needs to be declared as nullable. Also, this view model's associated search view model is treating this 'searchPages' live data value as nullable already and guarding against it accordingly.
Suppress all 'NullSafeMutableLiveData' instead of changing this 'mergeNotNull(...)' implementation and as such 'showSnackbarMessage' field's signature. This seems to be the safest choice for now.
Suppress this 'NullSafeMutableLiveData' instead of changing this 'MutableLiveData.postOnUi(...)' extension function and as such its signature seems to be the safest choice at the moment since this extension function is being utilized in extension places.
|
Moving this PR's milestone to |
…e-mutable-live-data-lint-errors Resolve `NullSafeMutableLiveData` Lint Errors
|
Found 1 violations: The PR caused the following dependency changes: +--- com.automattic:about:0.0.5
| +--- androidx.core:core-ktx:1.7.0
| | \--- androidx.core:core:1.7.0
-| | \--- androidx.lifecycle:lifecycle-runtime:2.3.1
-| | +--- androidx.arch.core:core-runtime:2.1.0
-| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | | \--- androidx.arch.core:core-common:2.1.0
-| | | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | +--- androidx.lifecycle:lifecycle-common:2.3.1
-| | | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | +--- androidx.arch.core:core-common:2.1.0 (*)
-| | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | \--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.1
+| | +--- androidx.arch.core:core-runtime:2.1.0
+| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | \--- androidx.arch.core:core-common:2.1.0
+| | | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | +--- androidx.lifecycle:lifecycle-common:2.4.1
+| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | \--- androidx.lifecycle:lifecycle-common-java8:2.4.1 (c)
+| | +--- androidx.arch.core:core-common:2.1.0 (*)
+| | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
| +--- com.google.android.material:material:1.4.0 -> 1.6.0-alpha01
| | +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1
| | | +--- androidx.activity:activity:1.2.4 -> 1.3.1
-| | | | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.1 (*)
-| | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1
-| | | | | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1
+| | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
| | | | +--- androidx.savedstate:savedstate:1.1.0
-| | | | | \--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.3.1 (*)
+| | | | | \--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.4.1 (*)
| | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1
-| | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1
-| | | | | +--- androidx.arch.core:core-common:2.1.0 (*)
-| | | | | +--- androidx.arch.core:core-runtime:2.1.0 (*)
-| | | | | \--- androidx.lifecycle:lifecycle-common:2.3.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 -> 2.4.1
+| | | | | +--- androidx.arch.core:core-common:2.1.0 (*)
+| | | | | +--- androidx.arch.core:core-runtime:2.1.0 (*)
+| | | | | \--- androidx.lifecycle:lifecycle-common:2.4.1 (*)
-| | | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
+| | | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-| | | +--- androidx.fragment:fragment:1.3.6
-| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | | | +--- androidx.core:core:1.2.0 -> 1.7.0 (*)
-| | | | +--- androidx.collection:collection:1.1.0 (*)
-| | | | +--- androidx.viewpager:viewpager:1.0.0
-| | | | | +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-| | | | | +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
-| | | | | \--- androidx.customview:customview:1.0.0 -> 1.1.0
-| | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | | | | +--- androidx.core:core:1.3.0 -> 1.7.0 (*)
-| | | | | \--- androidx.collection:collection:1.1.0 (*)
-| | | | +--- androidx.loader:loader:1.0.0
-| | | | | +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-| | | | | +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
-| | | | | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.2.0
-| | | | | | +--- androidx.arch.core:core-runtime:2.1.0 (*)
-| | | | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.2.0 -> 2.3.1 (*)
-| | | | | | \--- androidx.arch.core:core-common:2.1.0 (*)
-| | | | | \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.3.1 (*)
-| | | | +--- androidx.activity:activity:1.2.4 -> 1.3.1 (*)
-| | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 (*)
-| | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
-| | | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
-| | | | +--- androidx.savedstate:savedstate:1.1.0 (*)
-| | | | \--- androidx.annotation:annotation-experimental:1.0.0 -> 1.1.0
+| | | +--- androidx.fragment:fragment:1.3.6 -> 1.4.1
+| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | | +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+| | | | +--- androidx.collection:collection:1.1.0 (*)
+| | | | +--- androidx.viewpager:viewpager:1.0.0
+| | | | | +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+| | | | | +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+| | | | | \--- androidx.customview:customview:1.0.0 -> 1.1.0
+| | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | | | +--- androidx.core:core:1.3.0 -> 1.7.0 (*)
+| | | | | \--- androidx.collection:collection:1.1.0 (*)
+| | | | +--- androidx.loader:loader:1.0.0
+| | | | | +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+| | | | | +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+| | | | | +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.4.1
+| | | | | | +--- androidx.arch.core:core-common:2.1.0 (*)
+| | | | | | +--- androidx.arch.core:core-runtime:2.1.0 (*)
+| | | | | | \--- androidx.lifecycle:lifecycle-livedata-core:2.4.1 (*)
+| | | | | \--- androidx.lifecycle:lifecycle-viewmodel:2.0.0 -> 2.4.1 (*)
+| | | | +--- androidx.activity:activity:1.2.4 -> 1.3.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.3.1 -> 2.4.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
+| | | | +--- androidx.savedstate:savedstate:1.1.0 (*)
+| | | | +--- androidx.annotation:annotation-experimental:1.0.0 -> 1.1.0
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
-| | | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 (*)
+| | | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 -> 2.4.1 (*)
-| | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
+| | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-| | +--- androidx.fragment:fragment:1.0.0 -> 1.3.6 (*)
+| | +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
-| | +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.3.1 (*)
+| | +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.4.1 (*)
-| | +--- androidx.transition:transition:1.2.0 -> 1.3.0
-| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | | +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-| | | +--- androidx.collection:collection:1.1.0 (*)
-| | | \--- androidx.lifecycle:lifecycle-runtime:2.2.0 -> 2.3.1 (*)
+| | +--- androidx.transition:transition:1.2.0 -> 1.4.1
+| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+| | | \--- androidx.collection:collection:1.1.0 (*)
| | \--- androidx.viewpager2:viewpager2:1.0.0
-| | \--- androidx.fragment:fragment:1.1.0 -> 1.3.6 (*)
+| | \--- androidx.fragment:fragment:1.1.0 -> 1.4.1 (*)
| +--- androidx.compose.ui:ui:1.0.5 -> 1.1.0-beta04
-| | +--- androidx.lifecycle:lifecycle-common-java8:2.3.0
-| | | +--- androidx.lifecycle:lifecycle-common:2.3.0 -> 2.3.1 (*)
-| | | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | +--- androidx.lifecycle:lifecycle-common-java8:2.3.0 -> 2.4.1
+| | | +--- androidx.lifecycle:lifecycle-common:2.4.1 (*)
+| | | \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | +--- androidx.lifecycle:lifecycle-runtime:2.3.0 -> 2.3.1 (*)
+| | +--- androidx.lifecycle:lifecycle-runtime:2.3.0 -> 2.4.1 (*)
-| | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.0 -> 2.3.1 (*)
+| | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.0 -> 2.4.1 (*)
| | \--- androidx.profileinstaller:profileinstaller:1.1.0-beta04
-| | \--- androidx.startup:startup-runtime:1.0.0
+| | \--- androidx.startup:startup-runtime:1.0.0 -> 1.1.1
| +--- androidx.compose.ui:ui-tooling:1.0.5
| | +--- androidx.compose.material:material:1.0.5 -> 1.1.0-beta04
-| | | +--- androidx.lifecycle:lifecycle-runtime:2.3.0 -> 2.3.1 (*)
+| | | +--- androidx.lifecycle:lifecycle-runtime:2.3.0 -> 2.4.1 (*)
-| | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.0 -> 2.3.1 (*)
+| | | \--- androidx.lifecycle:lifecycle-viewmodel:2.3.0 -> 2.4.1 (*)
| | \--- androidx.activity:activity-compose:1.3.1
| | \--- androidx.activity:activity-ktx:1.3.1
-| | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1
-| | | +--- androidx.lifecycle:lifecycle-runtime:2.3.1 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.1 -> 1.5.2 (*)
-| | | \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+| | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1
+| | | +--- androidx.lifecycle:lifecycle-runtime:2.4.1 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+| | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
+| | | \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-| | \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1
-| | +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.10 (*)
-| | \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.4.1 -> 1.5.2 (*)
+| | \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1
+| | +--- androidx.lifecycle:lifecycle-viewmodel:2.4.1 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+| | \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.0 -> 1.5.2 (*)
| \--- androidx.navigation:navigation-compose:2.4.0-beta02
| +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.4.0-rc01
-| | \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.0 -> 2.3.1 (*)
+| | \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.0 -> 2.4.1 (*)
-| \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02
-| +--- androidx.navigation:navigation-runtime:2.4.0-beta02
-| | +--- androidx.navigation:navigation-common:2.4.0-beta02
-| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 (*)
-| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 (*)
-| | | +--- androidx.savedstate:savedstate:1.0.0 -> 1.1.0 (*)
-| | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
-| | | +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
-| | | \--- androidx.collection:collection-ktx:1.1.0
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.10 (*)
-| | | \--- androidx.collection:collection:1.1.0 (*)
-| | +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
-| | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 (*)
-| | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 (*)
-| | +--- androidx.annotation:annotation-experimental:1.1.0
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
-| \--- androidx.navigation:navigation-common-ktx:2.4.0-beta02
-| \--- androidx.navigation:navigation-common:2.4.0-beta02 (*)
+| \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02 -> 2.4.2
+| +--- androidx.navigation:navigation-runtime:2.4.2
+| | +--- androidx.navigation:navigation-common:2.4.2
+| | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1 (*)
+| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
+| | | +--- androidx.savedstate:savedstate:1.0.0 -> 1.1.0 (*)
+| | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 (*)
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+| | | +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
+| | | \--- androidx.collection:collection-ktx:1.1.0
+| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.20 -> 1.6.10 (*)
+| | | \--- androidx.collection:collection:1.1.0 (*)
+| | +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
+| | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.4.1 (*)
+| | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
+| | +--- androidx.annotation:annotation-experimental:1.1.0
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+| \--- androidx.navigation:navigation-common-ktx:2.4.2
+| \--- androidx.navigation:navigation-common:2.4.2 (*)
+--- com.automattic:stories:1.3.0
-| +--- androidx.navigation:navigation-fragment-ktx:2.0.0 -> 2.3.5
-| | +--- androidx.navigation:navigation-fragment:2.3.5
-| | | +--- androidx.fragment:fragment:1.2.4 -> 1.3.6 (*)
-| | | \--- androidx.navigation:navigation-runtime:2.3.5 -> 2.4.0-beta02 (*)
-| | +--- androidx.navigation:navigation-runtime-ktx:2.3.5 -> 2.4.0-beta02 (*)
-| | +--- androidx.fragment:fragment-ktx:1.2.4
-| | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.50 -> 1.6.10 (*)
-| | | +--- androidx.fragment:fragment:1.2.4 -> 1.3.6 (*)
-| | | +--- androidx.activity:activity-ktx:1.1.0 -> 1.3.1 (*)
-| | | +--- androidx.core:core-ktx:1.1.0 -> 1.7.0 (*)
-| | | +--- androidx.collection:collection-ktx:1.1.0 (*)
-| | | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.2.0
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.50 -> 1.6.10 (*)
-| | | | \--- androidx.lifecycle:lifecycle-livedata-core:2.2.0 -> 2.3.1 (*)
-| | | \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.3.1 (*)
-| | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.3.1 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 -> 1.6.10 (*)
+| +--- androidx.navigation:navigation-fragment-ktx:2.0.0 -> 2.4.2
+| | +--- androidx.navigation:navigation-fragment:2.4.2
+| | | +--- androidx.fragment:fragment-ktx:1.4.1
+| | | | +--- androidx.fragment:fragment:1.4.1 (*)
+| | | | +--- androidx.activity:activity-ktx:1.2.3 -> 1.3.1 (*)
+| | | | +--- androidx.core:core-ktx:1.2.0 -> 1.7.0 (*)
+| | | | +--- androidx.collection:collection-ktx:1.1.0 (*)
+| | | | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.3.1 -> 2.4.1
+| | | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.4.1 (*)
+| | | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.4.1 (*)
+| | | | +--- androidx.savedstate:savedstate-ktx:1.1.0 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.31 -> 1.6.10 (*)
+| | | +--- androidx.navigation:navigation-runtime:2.4.2 (*)
+| | | +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0
+| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+| | | | +--- androidx.customview:customview:1.1.0 (*)
+| | | | +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+| | | | +--- androidx.window:window:1.0.0
+| | | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+| | | | | +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 (*)
+| | | | | +--- androidx.annotation:annotation:1.2.0
+| | | | | +--- androidx.collection:collection:1.1.0 (*)
+| | | | | \--- androidx.core:core:1.3.2 -> 1.7.0 (*)
+| | | | \--- androidx.transition:transition:1.4.1 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.6.10 (*)
+| | \--- androidx.navigation:navigation-runtime-ktx:2.4.2 (*)
-| +--- androidx.navigation:navigation-ui-ktx:2.0.0 -> 2.3.5
-| | +--- androidx.navigation:navigation-ui:2.3.5
-| | | +--- androidx.navigation:navigation-runtime:2.3.5 -> 2.4.0-beta02 (*)
-| | | +--- androidx.customview:customview:1.1.0 (*)
-| | | +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-| | | +--- com.google.android.material:material:1.0.0 -> 1.6.0-alpha01 (*)
-| | | \--- androidx.transition:transition:1.3.0 (*)
-| | +--- androidx.navigation:navigation-runtime-ktx:2.3.5 -> 2.4.0-beta02 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 -> 1.6.10 (*)
+| +--- androidx.navigation:navigation-ui-ktx:2.0.0 -> 2.4.2
+| | +--- androidx.navigation:navigation-ui:2.4.2
+| | | +--- androidx.navigation:navigation-runtime:2.4.2 (*)
+| | | +--- androidx.customview:customview:1.1.0 (*)
+| | | +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+| | | +--- com.google.android.material:material:1.4.0-beta01 -> 1.6.0-alpha01 (*)
+| | | +--- androidx.annotation:annotation-experimental:1.1.0
+| | | \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+| | \--- androidx.navigation:navigation-runtime-ktx:2.4.2 (*)
| +--- com.github.bumptech.glide:glide:4.10.0 -> 4.11.0
-| | \--- androidx.fragment:fragment:1.0.0 -> 1.3.6 (*)
+| | \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
| +--- com.automattic.stories:photoeditor:1.3.0
| | \--- androidx.camera:camera-core:1.0.0-alpha06
-| | +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.2.0 (*)
+| | +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.4.1 (*)
-| | \--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.3.1 (*)
+| | \--- androidx.lifecycle:lifecycle-common:2.1.0 -> 2.4.1 (*)
-| +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.3.0 (*)
+| +--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.4.1 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.3.1 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.4.1 (*)
-| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.50 -> 1.6.10 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.0 -> 1.5.2 (*)
-| +--- androidx.lifecycle:lifecycle-livedata:2.2.0 (*)
-| \--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.2.0 (*)
+| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 -> 2.4.1
+| +--- androidx.lifecycle:lifecycle-livedata:2.4.1 (*)
+| +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.4.1 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
+| \--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.0 -> 1.5.2 (*)
+--- project :libs:image-editor:ImageEditor
-| +--- androidx.navigation:navigation-fragment-ktx:2.3.5 (*)
+| +--- androidx.navigation:navigation-fragment-ktx:2.4.2 (*)
-| +--- androidx.navigation:navigation-ui-ktx:2.3.5 (*)
+| +--- androidx.navigation:navigation-ui-ktx:2.4.2 (*)
-| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.3.1 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.1 (*)
-| +--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 (*)
+| +--- androidx.lifecycle:lifecycle-livedata-ktx:2.4.1 (*)
| \--- com.github.yalantis:ucrop:2.2.4
-| \--- androidx.transition:transition:1.2.0-rc01 -> 1.3.0 (*)
+| \--- androidx.transition:transition:1.2.0-rc01 -> 1.4.1 (*)
-+--- androidx.lifecycle:lifecycle-extensions:2.2.0
-| +--- androidx.lifecycle:lifecycle-runtime:2.2.0 -> 2.3.1 (*)
-| +--- androidx.arch.core:core-common:2.1.0 (*)
-| +--- androidx.arch.core:core-runtime:2.1.0 (*)
-| +--- androidx.fragment:fragment:1.2.0 -> 1.3.6 (*)
-| +--- androidx.lifecycle:lifecycle-common:2.2.0 -> 2.3.1 (*)
-| +--- androidx.lifecycle:lifecycle-livedata:2.2.0 (*)
-| +--- androidx.lifecycle:lifecycle-process:2.2.0
-| | \--- androidx.lifecycle:lifecycle-runtime:2.2.0 -> 2.3.1 (*)
-| +--- androidx.lifecycle:lifecycle-service:2.2.0
-| | \--- androidx.lifecycle:lifecycle-runtime:2.2.0 -> 2.3.1 (*)
-| \--- androidx.lifecycle:lifecycle-viewmodel:2.2.0 -> 2.3.1 (*)
-+--- androidx.lifecycle:lifecycle-runtime-ktx:2.2.0 -> 2.3.1 (*)
++--- androidx.lifecycle:lifecycle-runtime-ktx:2.4.1 (*)
+--- androidx.legacy:legacy-support-core-ui:1.0.0
-| \--- androidx.slidingpanelayout:slidingpanelayout:1.0.0
-| +--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-| +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
-| \--- androidx.customview:customview:1.0.0 -> 1.1.0 (*)
+| \--- androidx.slidingpanelayout:slidingpanelayout:1.0.0 -> 1.2.0 (*)
-+--- androidx.fragment:fragment:1.2.4 -> 1.3.6 (*)
++--- androidx.fragment:fragment:1.2.4 -> 1.4.1 (*)
-+--- androidx.fragment:fragment-ktx:1.2.4 (*)
++--- androidx.fragment:fragment-ktx:1.2.4 -> 1.4.1 (*)
+--- androidx.legacy:legacy-support-v4:1.0.0
-| \--- androidx.fragment:fragment:1.0.0 -> 1.3.6 (*)
+| \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+--- androidx.preference:preference:1.1.0
-| \--- androidx.fragment:fragment:1.1.0 -> 1.3.6 (*)
+| \--- androidx.fragment:fragment:1.1.0 -> 1.4.1 (*)
+--- androidx.work:work-runtime:2.7.0
-| +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.2.0 (*)
+| +--- androidx.lifecycle:lifecycle-livedata:2.1.0 -> 2.4.1 (*)
-| +--- androidx.startup:startup-runtime:1.0.0 (*)
+| +--- androidx.startup:startup-runtime:1.0.0 -> 1.1.1 (*)
-| \--- androidx.lifecycle:lifecycle-service:2.1.0 -> 2.2.0 (*)
+| \--- androidx.lifecycle:lifecycle-service:2.1.0
+| \--- androidx.lifecycle:lifecycle-runtime:2.1.0 -> 2.4.1 (*)
+--- androidx.work:work-gcm:2.7.0
| \--- com.google.android.gms:play-services-gcm:17.0.0
| \--- com.google.android.gms:play-services-base:17.0.0 -> 17.1.0
-| +--- androidx.fragment:fragment:1.0.0 -> 1.3.6 (*)
+| +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
| \--- com.google.android.gms:play-services-basement:17.0.0 -> 17.1.1
-| \--- androidx.fragment:fragment:1.0.0 -> 1.3.6 (*)
+| \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
-+--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.2.0 -> 2.3.1 (*)
++--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.1 (*)
-+--- androidx.lifecycle:lifecycle-livedata-ktx:2.2.0 (*)
++--- androidx.lifecycle:lifecycle-livedata-ktx:2.4.1 (*)
-+--- androidx.lifecycle:lifecycle-process:2.2.0 (*)
++--- androidx.lifecycle:lifecycle-process:2.4.1
+| +--- androidx.lifecycle:lifecycle-runtime:2.4.1 (*)
+| +--- androidx.startup:startup-runtime:1.1.1 (*)
+| \--- androidx.annotation:annotation:1.2.0
+--- com.google.android.gms:play-services-auth:18.1.0
-| \--- androidx.fragment:fragment:1.0.0 -> 1.3.6 (*)
+| \--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+--- com.automattic:Automattic-Tracks-Android:2.2.0
| \--- io.sentry:sentry-android -> 5.4.3
| \--- io.sentry:sentry-android-core:5.4.3
-| +--- androidx.lifecycle:lifecycle-process:2.2.0 (*)
+| +--- androidx.lifecycle:lifecycle-process:2.2.0 -> 2.4.1 (*)
-| \--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.3.0 (*)
+| \--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.4.1 (*)
+--- com.google.dagger:dagger-android-support:2.41
-| +--- androidx.fragment:fragment:1.3.6 (*)
+| +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-| +--- androidx.lifecycle:lifecycle-common:2.3.1 (*)
+| +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-| \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
+| \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+--- com.google.dagger:hilt-android:2.41
-| +--- androidx.fragment:fragment:1.3.6 (*)
+| +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-| +--- androidx.lifecycle:lifecycle-common:2.3.1 (*)
+| +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-| \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 (*)
+| \--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+--- org.wordpress:fluxc:{strictly 1.44.1} -> 1.44.1
| \--- androidx.paging:paging-runtime:2.1.2
-| +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.3.1 (*)
+| +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.4.1 (*)
-| \--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.2.0 (*)
+| \--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.4.1 (*)
+--- project :libs:editor:WordPressEditor
| \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.77.0
| \--- org.wordpress-mobile:react-native-screens:2.9.0
-| \--- androidx.fragment:fragment:1.2.1 -> 1.3.6 (*)
+| \--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
+--- com.zendesk:support:5.0.2
| \--- com.zendesk:guide:1.0.1
| \--- com.zendesk:messaging:5.1.0
| \--- com.zendesk:common-ui:4.0.1
| \--- com.zendesk.belvedere2:belvedere:3.0.0-RC
| +--- com.zendesk.belvedere2:belvedere-core:3.0.0-RC
-| | \--- androidx.fragment:fragment:1.2.5 -> 1.3.6 (*)
+| | \--- androidx.fragment:fragment:1.2.5 -> 1.4.1 (*)
-| \--- androidx.fragment:fragment:1.2.5 -> 1.3.6 (*)
+| \--- androidx.fragment:fragment:1.2.5 -> 1.4.1 (*)
Please review and act accordingly
|
|
👋 @oguzkocer !
Great, thank you so much, I am on it! 🏃 🥇 |
There was a problem hiding this comment.
👋 @oguzkocer !
I reviewed and tested this PR again, this time even more thoroughly with my general smoke testing and my more focused image editor testing, everything looks good and I didn't encounter any hiccups.
As per our conversation here and us staying practical and go with option 1, I agree, let's merge this to trunk and then update the Plugin DSL PR accordingly to move forward.
As far as the transitive dependencies are concerned, I took a closer look at the dependency tree diff and the "main" dependencies I see this PR affecting is the below:
For the Lifecycle part, we already handled that with more care, as part of this accompanying PR of mine, and then reviewed it in more detail.
For the Fragment part I can note the below:
- I am seeing on most occasions that the transitive fragment
1.3.6dependency is being updated to1.4.1for thecom.automattic.about,com.automattic.stories,androidx.legacy,androidx.preference,androidx.work,com.google.android.gms,com.google.dagger,com.zendesklibraries and ourlibs:editormodule. - This means to me that the changes we should expect are:
- Version 1.4.0 related, which as far as I can tell is:
FragmentStrictMode, new API that is not affecting us.FragmentContainerView, new API that is not affecting us.FragmentScenario, new implementation that is not affecting us.FragmentTransaction, new transaction that is not affecting us.FragmentManager, new experimental API that is not affecting us.Multiple back stacks🥳 ...but not affecting us.
- Version 1.4.1 related, which as far as I can tell is:
Bug Fixes, which are good to have on top of1.4.0anyway, thus not affecting us.
- Version 1.4.0 related, which as far as I can tell is:
As such, I am comfortable enough that this change will not break our app, at least to the extend that we wouldn't be able to recover fast afterwards. @ashiagr it would be great if I get a second opinion on that too in case I am missing something vital.
PS: In addition to that and since we already did the Fragment update work, in terms of verifying everything works as expected in our app, we could create another PR right after this one to explicitly update out current outdate 1.2.4 fragment version to 1.4.1. I'll can create an issue on that right now so that we don't forget (done #16678).
|
Thanks for the investigation for the transitive dependency updates @ParaskP7! I agree that with Since @ashiagr reviewed both this PR as well as the #16647, I am going to merge this PR now to keep things moving for @ParaskP7's project. However, @ashiagr if you have any other feedback, please let me know and I'll prioritize opening a new PR to address it. |
This PR updates navigation component version from
2.3.5to2.4.2.This PR is a prerequisite for the
Plugin DSLPR #15314. This is because2.3.5version of the component is requestingorg.jetbrains.kotlin:kotlin-compiler-embeddable:1.4.31which creates a conflict with our Kotlin version1.6.10. I am not entirely sure why the conflict only happens with the plugin DSL changes, and I am sure there are other ways to address this issue, but upgrading this dependency seemed like the best way forward for us.I realized the lint issue from the initial commit after I've opened the PR because the task wasn't failing for me locally. I looked into the issue and ended up disabling the new lint check for
NullSafeMutableLiveDatadue to bugs within our dependencies. The lint error also makes it clear that the crash is happening within lint checks and not in our application. I've documented my findings and the reason for disabling check as a comment. When the issue withinlifecycle-livedatais resolved, we can look into re-enabling the check along with fixing 20+ new issues it raises 😱Fixing this ^ lint issue resulted in a couple
FragmentLiveDataObservelint errors, another new lint check as far as I can tell. Thankfully addressing those in 2d2973d was a lot simpler with a change that's consistent with our codebase.Looking through the release notes for
2.4.0, the only breaking change as far as I can tell is the following:The only error we got from this change is due to
outputFileExtensionbeing nullable inPreviewImageFragment. I have no familiarity with the code, so I went with anull-check since we already have another one forR.id.preview_dest. However, I can see theoutputFileExtensionbeing optional, so I was hoping @ashiagr could help me with the correct approach here.This sounds like another breaking change, however declaring dependencies section still refers to the
-ktxversions for Kotlin and the dependencies are still being fetched successfully. There is also no instructions in the release notes to update the dependency declaratoin, so I am leaning towards leaving them as is for now.Version 2.4.1 & 2.4.2 only contain bug fixes - which is expected since they are just patches.
To test:
I have no familiarity with Navigation component or how it's used. So, I just did a smoke test of the PR. It'd be great if someone who is familiar with the component and its usage in our app can do a more detailed testing. I am hoping @ashiagr can help with that. 🙇♂️
Regression Notes
outputExtensionis missing while previewing. To address this concern, I asked for help from a more experienced developer to verify it's handled correctly.What I did to test those areas of impact (or what existing automated tests I relied on)
I don't know if we have tests that cover navigation component. I did a smoke test and pinged a more experienced developer to help test the changes.
What automated tests I added (or what prevented me from doing so)
Adding new tests is out of the scope for this PR.
PR submission checklist:
RELEASE-NOTES.txtif necessary.